Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stale flags (FE) #3606

Merged
merged 23 commits into from
Apr 18, 2024
Merged

feat: stale flags (FE) #3606

merged 23 commits into from
Apr 18, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Mar 13, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Allows defining whether a tag indicates a permanent feature
  • Prevents deletion / adds icon for system generated tags
  • Adds tooltip for STALE tags
  • Standardises rendering tag content
  • Resets create/edit tag modal on close (before it would stay on the create tag state)
  • Fixes a 1px tooltip arrow gap and incorrect background
tags.mov

How did you test this code?

Please describe.

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 6:08pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 6:08pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 6:08pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Mar 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Uffizzi Preview deployment-49969 was deleted.

matthewelwell
matthewelwell reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this tooltip as well based on the addition of the is_permanent attribute:

image

frontend/web/components/tags/TagContent.tsx Outdated Show resolved Hide resolved
frontend/api/index.js Outdated Show resolved Hide resolved
@kyle-ssg @matthewelwell
Update frontend/web/components/tags/TagContent.tsx
d3f6ff1 
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
@kyle-ssg kyle-ssg linked an issue Apr 10, 2024 that may be closed by this pull request
Protected flag tags feature is not findable #576
Closed
@matthewelwell
Copy link
Contributor

@kyle-ssg one thing I've noticed here is that the FE seems to let you edit the project setting regardless of the plan that the organisation has. The API restricts this to enterprise subscriptions only - can we update this?

@kyle-ssg
Copy link
Member Author

@matthewelwell ah thanks, that has been updated now.

@matthewelwell
Copy link
Contributor

@kyle-ssg we might want to consider some extra documentation around this somewhere (not exactly sure where yet), because this feature will only work with feature versioning enabled. Perhaps an extra line on the tooltips for the setting in projects settings and the one on the tag itself?

@kyle-ssg
Copy link
Member Author

Hmmm I guess this will be a little tricky since versioning is enabled per environment.

I'll note it in the tooltip and also start managing this UI with the versioning feature flag

@matthewelwell
Copy link
Contributor

@kyle-ssg looks like this has broken:

image

@kyle-ssg
Copy link
Member Author

@matthewelwell sorted

@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit 424b754 Apr 18, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the feat/stale-flags branch April 18, 2024 15:12
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protected flag tags feature is not findable Show "stale" flags
3 participants
@kyle-ssg @matthewelwell @novakzaballa