wip: Add feature_last_updated_at to featurestate #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagantrivedi
commented
Aug 2, 2021
api/features/serializers.py
Outdated
| @@ -141,11 +142,20 @@ class FeatureStateSerializerBasic(WritableNestedModelSerializer): | |||
| multivariate_feature_state_values = MultivariateFeatureStateValueSerializer( | |||
| many=True, required=False | |||
| ) | |||
| # TODO: better variable name | |||
| feature_last_updated_since = serializers.SerializerMethodField() | |||
There was a problem hiding this comment.
@matthewelwell can you help with the name?
There was a problem hiding this comment.
Is this a datetime or an integer?
If datetime: feature_last_updated_at
If integer: days_since_feature_last_updated
There was a problem hiding this comment.
yeah, it's an integer.
There was a problem hiding this comment.
Let's go with days_since_feature_last_updated then.
gagantrivedi
force-pushed
the
feat/github-184/stale-flags
branch
from
b944ccc
to
789ac8b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.