-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable per-identity overrides in Local Evaluation mode #1762
Comments
From a frontend perspective, I think that the only requirement is to show an appropriate error when adding an override in the dashboard fails ? Potentially if we return this usage in /environments/:id I can display a warning too. |
Please assign back to me when we have a method to retrieving / detecting max identity overrides. |
The only thing left here, is to support pagination, which only affects very large environments. I have created a separate issue to track the progress of this here. |
Overview
There is currently a functional deficiency in running the SDKs in Local Evaluation mode in that they ignore Identity overrides. This issue seeks to fix that deficiency. To do this, we plan to implement an (optional) limit to the number of Identity overrides per Environment.
Caveats that would be solved by Identity limiting
Allow for Identity overrides in Local Evaluation mode
When running the server side SDKs in Local Evaluation mode, we don't store any of the Identity overrides in the
GET Environment Document
endpoint as it could contain unlimited data. If we limited the number of Identity overrides, we could include that either in the main Environment document or as a supplementary endpoint. With these two pieces of data, local evaluation mode would include Identity Overrides.Show identity overrides for an environment
When moving to Edge, we removed the option of seeing a list of Indentities that are overriding a particular Environment, as we have no index that can form this data. Limiting the number of overrides would allow us to store this data as a single large object of denormalised data. We could then reintroduce this view.
Technical Approach
If we limited the number of Identity overrides we could store the override data as a single piece, either in the main Environment document or as a supplementary endpoint. With these two pieces of data, local evaluation mode would include Identity Overrides.
Questions and Complications
The text was updated successfully, but these errors were encountered: