Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identity-targeted segment conditions #197

Open
khvn26 opened this issue Dec 6, 2023 · 1 comment · May be fixed by #198
Open

Identity-targeted segment conditions #197

khvn26 opened this issue Dec 6, 2023 · 1 comment · May be fixed by #198
Assignees
@khvn26

Comments

@khvn26
Copy link
Member

khvn26 commented Dec 6, 2023 •
edited
Loading

To support flagsmith#1762:

  1. Modify evaluate_identity_in_segment logic so the segment value is matched against the identity identifier in case the SegmentCondition.property_ value is set to a special value "_$identity.identifier".

  2. Add Segment.metadata field.

This will be a reference implementation for the rest of our SDKs.
@khvn26 khvn26 self-assigned this Dec 6, 2023
@khvn26 khvn26 linked a pull request Dec 7, 2023 that will close this issue
Open
@khvn26
Copy link
Member Author

khvn26 commented Dec 7, 2023

This is now not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khvn26 khvn26

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@khvn26