Add support for PPP mode #38
Annotations
47 warnings
rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
rustfmt
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`:
src/asynch/network.rs#L59
warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
--> src/asynch/network.rs:59:13
|
59 | / match embassy_futures::select::select(
60 | | self.urc_subscription.next_message_pure(),
61 | | self.ch.wait_for_wifi_state_change(),
62 | | )
... |
73 | | _ => {}
74 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
59 ~ if let embassy_futures::select::Either::First(event) = embassy_futures::select::select(
60 + self.urc_subscription.next_message_pure(),
61 + self.ch.wait_for_wifi_state_change(),
62 + )
63 + .await {
64 + #[cfg(feature = "edm")]
65 + let Some(event) = event.extract_urc() else {
66 + continue;
67 + };
68 +
69 + self.handle_urc(event).await?;
70 + }
|
|
sub-expression diverges:
/rustc/129f3b9964af4d4a709d1383930ade12dfe7c081/library/core/src/panic.rs#L106
warning: sub-expression diverges
--> src/asynch/control.rs:523:77
|
523 | config_param: WifiStationConfig::WpaPskOrPassphrase(todo!("hex values?!")),
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#diverging_sub_expression
= note: `#[warn(clippy::diverging_sub_expression)]` on by default
= note: this warning originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)
|
method `start_ap` is never used:
src/asynch/control.rs#L310
warning: method `start_ap` is never used
--> src/asynch/control.rs:310:14
|
139 | / impl<'a, const INGRESS_BUF_SIZE: usize, const URC_CAPACITY: usize>
140 | | Control<'a, INGRESS_BUF_SIZE, URC_CAPACITY>
| |_______________________________________________- method in this implementation
...
310 | async fn start_ap(&self, ssid: &str) -> Result<(), Error> {
| ^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
unused variable: `psk`:
src/asynch/control.rs#L512
warning: unused variable: `psk`
--> src/asynch/control.rs:512:41
|
512 | WifiAuthentication::Wpa2Psk(psk) => {
| ^^^ help: if this is intentional, prefix it with an underscore: `_psk`
|
unreachable call:
src/asynch/control.rs#L523
warning: unreachable call
--> src/asynch/control.rs:523:39
|
523 | config_param: WifiStationConfig::WpaPskOrPassphrase(todo!("hex values?!")),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ --------------------- any code following this expression is unreachable
| |
| unreachable call
|
= note: `#[warn(unreachable_code)]` on by default
|
unused variable: `channel`:
src/asynch/control.rs#L440
warning: unused variable: `channel`
--> src/asynch/control.rs:440:73
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel`
|
unused variable: `passphrase`:
src/asynch/control.rs#L440
warning: unused variable: `passphrase`
--> src/asynch/control.rs:440:55
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_passphrase`
|
unused variable: `ssid`:
src/asynch/control.rs#L440
warning: unused variable: `ssid`
--> src/asynch/control.rs:440:43
|
440 | pub async fn start_ap_wpa2(&mut self, ssid: &str, passphrase: &str, channel: u8) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_ssid`
|
unused variable: `channel`:
src/asynch/control.rs#L435
warning: unused variable: `channel`
--> src/asynch/control.rs:435:55
|
435 | pub async fn start_ap_open(&mut self, ssid: &str, channel: u8) {
| ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_channel`
|
unused variable: `ssid`:
src/asynch/control.rs#L435
warning: unused variable: `ssid`
--> src/asynch/control.rs:435:43
|
435 | pub async fn start_ap_open(&mut self, ssid: &str, channel: u8) {
| ^^^^ help: if this is intentional, prefix it with an underscore: `_ssid`
|
= note: `#[warn(unused_variables)]` on by default
|
redundant field names in struct initialization:
src/asynch/control.rs#L151
warning: redundant field names in struct initialization
--> src/asynch/control.rs:151:13
|
151 | urc_channel: urc_channel,
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `urc_channel`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
= note: `#[warn(clippy::redundant_field_names)]` on by default
|
clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Test
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Test:
src/asynch/control.rs#L435
unused variable: `ssid`
|
Test:
src/asynch/control.rs#L435
unused variable: `channel`
|
Test:
src/asynch/control.rs#L440
unused variable: `ssid`
|
Test:
src/asynch/control.rs#L440
unused variable: `passphrase`
|
Test:
src/asynch/control.rs#L440
unused variable: `channel`
|
Test:
src/asynch/control.rs#L523
unreachable call
|
Test:
src/asynch/control.rs#L512
unused variable: `psk`
|
Test:
src/asynch/control.rs#L310
method `start_ap` is never used
|
Test
`ublox-short-range-rs` (lib) generated 8 warnings
|
Test:
src/asynch/control.rs#L435
unused variable: `ssid`
|
Test:
src/asynch/control.rs#L435
unused variable: `channel`
|
Test:
src/asynch/control.rs#L440
unused variable: `ssid`
|
Test:
src/asynch/control.rs#L440
unused variable: `passphrase`
|
Test:
src/asynch/control.rs#L440
unused variable: `channel`
|
Test:
src/asynch/control.rs#L523
unreachable call
|
Test:
src/asynch/control.rs#L512
unused variable: `psk`
|
Test:
src/asynch/control.rs#L310
method `start_ap` is never used
|
Test
`ublox-short-range-rs` (lib test) generated 8 warnings
|