Support events. #94
Merged
Support events. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrainger
reviewed
Jul 4, 2024
Comment on lines
+251
to
+255
| #if NET6_0_OR_GREATER | ||
| stream = await httpResponse.Content.ReadAsStreamAsync(cancellationToken).ConfigureAwait(false); | ||
| #else | ||
| stream = await httpResponse.Content.ReadAsStreamAsync().ConfigureAwait(false); | ||
| #endif |
There was a problem hiding this comment.
Could you do await using var vs using var here (and drop the code in the finally block)?
bgrainger
reviewed
Jul 4, 2024
Comment on lines
+324
to
+328
| #if NETSTANDARD2_1_OR_GREATER || NET6_0_OR_GREATER | ||
| await stream.WriteAsync(s_errorEventLine, cancellationToken).ConfigureAwait(false); | ||
| #else | ||
| await stream.WriteAsync(s_errorEventLine.ToArray(), 0, s_errorEventLine.Length, cancellationToken).ConfigureAwait(false); | ||
| #endif |
There was a problem hiding this comment.
Defining an extension method (for WriteAsync on old frameworks) that takes Memory<T> and uses MemoryMarshal.TryGetArray (or ToArray, but I assume the former should work) can avoid needing to sprinkle all these #if through the rest of the code.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.