Don't use ToArray unless needed for JSON source gen.

FacilityApi · Jun 18, 2024 · 8a0df9f · 8a0df9f
1 parent 6e9f2fe
commit 8a0df9f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Facility.CodeGen.CSharp/CSharpGenerator.cs b/src/Facility.CodeGen.CSharp/CSharpGenerator.cs
@@ -865,7 +865,7 @@ private CodeGenFile GenerateHttpMapping(HttpServiceInfo httpServiceInfo, Context
 									code.WriteLine($"RequestBodyType = typeof({requestBodyFieldTypeName.TrimEnd('?')}),");
 									if (httpMethodInfo.RequestBodyField.ContentType != null)
 										code.WriteLine($"RequestBodyContentType = {CSharpUtility.CreateString(httpMethodInfo.RequestBodyField.ContentType)},");
-									code.WriteLine($"GetRequestBody = request => request.{requestBodyFieldName}{(requestBodyFieldInfo.Kind == ServiceTypeKind.Array ? "?.ToArray()" : "")},");
+									code.WriteLine($"GetRequestBody = request => request.{requestBodyFieldName}{(ShouldGenerateJsonSource && requestBodyFieldInfo.Kind == ServiceTypeKind.Array ? "?.ToArray()" : "")},");
 									code.WriteLine($"CreateRequest = body => new {requestTypeName} {{ {requestBodyFieldName} = ({requestBodyFieldTypeName}) body }},");
 								}
 								else if (httpMethodInfo.RequestNormalFields.Any())
@@ -934,7 +934,7 @@ private CodeGenFile GenerateHttpMapping(HttpServiceInfo httpServiceInfo, Context
 													if (bodyField.ContentType != null)
 														code.WriteLine($"ResponseBodyContentType = {CSharpUtility.CreateString(bodyField.ContentType)},");
 													code.WriteLine($"MatchesResponse = response => response.{responseBodyFieldName} != null,");
-													code.WriteLine($"GetResponseBody = response => response.{responseBodyFieldName}{(bodyFieldType.Kind == ServiceTypeKind.Array ? "?.ToArray()" : "")},");
+													code.WriteLine($"GetResponseBody = response => response.{responseBodyFieldName}{(ShouldGenerateJsonSource && bodyFieldType.Kind == ServiceTypeKind.Array ? "?.ToArray()" : "")},");
 													code.WriteLine($"CreateResponse = body => new {responseTypeName} {{ {responseBodyFieldName} = ({responseBodyFieldTypeName}) body }},");
 												}
 											}