Merge pull request #90 from ejball/clone-settings

Directory.Build.props

@@ -1,8 +1,8 @@
 <Project>
 
   <PropertyGroup>
-    <VersionPrefix>2.23.1</VersionPrefix>
-    <PackageValidationBaselineVersion>2.23.0</PackageValidationBaselineVersion>
+    <VersionPrefix>2.24.0</VersionPrefix>
+    <PackageValidationBaselineVersion>2.23.1</PackageValidationBaselineVersion>
     <LangVersion>12.0</LangVersion>
     <Nullable>enable</Nullable>
     <ImplicitUsings>enable</ImplicitUsings>

ReleaseNotes.md

@@ -1,5 +1,10 @@
 # Release Notes
 
+## 2.24.0
+
+* Add `HttpClientServiceSettings.Clone`.
+* Support collection syntax with MessagePack properties.
+
 ## 2.23.1
 
 * Throw `ArgumentNullException` instead of `NullReferenceException` when using `ServiceDelegators.Validate` with a null request.

src/Facility.Core/Http/HttpClientServiceSettings.cs

@@ -55,4 +55,21 @@ public sealed class HttpClientServiceSettings
 	/// True to prevent the validation of response DTOs after receiving.
 	/// </summary>
 	public bool SkipResponseValidation { get; set; }
+
+	/// <summary>
+	/// Creates a deep clone of the instance.
+	/// </summary>
+	public HttpClientServiceSettings Clone() => new()
+	{
+		BaseUri = BaseUri,
+		HttpClient = HttpClient,
+		ContentSerializer = ContentSerializer,
+		BytesSerializer = BytesSerializer,
+		TextSerializer = TextSerializer,
+		DisableChunkedTransfer = DisableChunkedTransfer,
+		Aspects = Aspects?.ToList(),
+		Synchronous = Synchronous,
+		SkipRequestValidation = SkipRequestValidation,
+		SkipResponseValidation = SkipResponseValidation,
+	};
 }

tests/Facility.Core.UnitTests/Http/HttpClientServiceSettingsTests.cs

@@ -0,0 +1,44 @@
+using System.Collections;
+using Facility.Core.Http;
+using FluentAssertions;
+using NUnit.Framework;
+
+namespace Facility.Core.UnitTests.Http;
+
+public class HttpClientServiceSettingsTests
+{
+	[Test]
+	public async Task CloneSettings()
+	{
+		var original = new HttpClientServiceSettings
+		{
+			BaseUri = new Uri("https://example.com"),
+			HttpClient = new HttpClient(),
+			ContentSerializer = HttpContentSerializer.Create(SystemTextJsonServiceSerializer.Instance),
+			BytesSerializer = BytesHttpContentSerializer.Instance,
+			TextSerializer = TextHttpContentSerializer.Instance,
+			DisableChunkedTransfer = true,
+			Aspects = Array.Empty<HttpClientServiceAspect>(),
+			Synchronous = true,
+			SkipRequestValidation = true,
+			SkipResponseValidation = true,
+		};
+
+		var clone = original.Clone();
+
+		foreach (var property in typeof(HttpClientServiceSettings).GetProperties())
+		{
+			var propertyType = property.PropertyType;
+
+			var originalValue = property.GetValue(original);
+			var nullOrDefault = propertyType.IsValueType && Nullable.GetUnderlyingType(propertyType) is null ? Activator.CreateInstance(propertyType) : null;
+			originalValue.Should().NotBe(nullOrDefault, $"original {property.Name} should not be null/default.");
+
+			var clonedValue = property.GetValue(clone);
+			if (clonedValue is IEnumerable and not string)
+				clonedValue.Should().BeEquivalentTo(originalValue, $"cloned {property.Name} should be equivalent to original.");
+			else
+				clonedValue.Should().Be(originalValue, $"cloned {property.Name} should be equal to original.");
+		}
+	}
+}