Tactics: refactor a bit to avoid a cycle #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tactics.MApply.fsti is using typeclasses, which is only working because of the non-staged build. Conceptually, this is wrong, as any change to the typeclass resolution/generation will not be in effect when checking Tactics.MApply. This becomes a concrete problem in the staged build. This commit refactors MApply to separate its core (mapply0) from the typeclass interface. This will allow us to make mapply0 a plugin without any circularity with the typeclass plugins.
|
mls-star failed in that run, but I'm pretty sure it's unrelated (REPROSEC/dolev-yao-star-extrinsic@4fe16e8#commitcomment-147926988), so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tactics.MApply.fsti is using typeclasses, which is only working because
of the non-staged build. Conceptually, this is wrong, as any change to
the typeclass resolution/generation will not be in effect when checking
Tactics.MApply. This becomes a concrete problem in the staged build.
This commit refactors MApply to separate its core (mapply0) from the
typeclass interface. This will allow us to make mapply0 a plugin without
any circularity with the typeclass plugins.