Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading node_modules and MNV fix #68

Closed
wants to merge 3 commits into from

Conversation

JustinAronson
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration Tests
  • Unit Tests

@mihaitodor
Copy link
Collaborator

Hey @JustinAronson, I don't know much about what this stuff does, but do we really need to add all these files to the repo? I worry that they'll bloat the git history. Ideally, such packages are pulled directly from a CDN at build / deploy time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants