Skip to content

Commit

Permalink
Update Node to Node 18 (#147)
Browse files Browse the repository at this point in the history
Update the .tool-versions and CI scripts to Node 18. This also requires a temporary workaround to avoid SSL errors when running or building the app (NODE_OPTIONS=--openssl-legacy-provider). According to the interwebs, we can back out that workaround  once we update react-scripts to v5 or greater.
  • Loading branch information
cmoesel authored Sep 29, 2023
1 parent ca179ae commit d8719fc
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '18'
- run: npm install
- run: npm run lint
- run: npm run prettier
env:
CI: true
test:
name: Test on node 12 and ubuntu
name: Test on node 18 and ubuntu
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Use Node.js 12
- name: Use Node.js 18
uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '18'
- run: npm install
- run: npm test
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: '12.x'
node-version: '18'
- run: npm install
- run: npm run build
env:
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 16.19.0
nodejs 18.18.0
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@
}
},
"scripts": {
"start": "react-app-rewired start",
"build": "react-app-rewired build",
"start": "NODE_OPTIONS=--openssl-legacy-provider react-app-rewired start",
"build": "NODE_OPTIONS=--openssl-legacy-provider react-app-rewired build",
"serve-build": "node scripts/serve-build.js",
"lint": "eslint \"./src/**/*.js\"",
"lint-fix": "eslint \"./src/**/*.js\" --fix",
Expand Down

0 comments on commit d8719fc

Please sign in to comment.