Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed folder case to lowercase for uniformity. #1025

Closed
wants to merge 1 commit into from
Closed

Changed folder case to lowercase for uniformity. #1025

wants to merge 1 commit into from

Conversation

tux-box
Copy link

@tux-box tux-box commented Sep 22, 2022

Changing the folder names to lowercase for uniformity and better linux os support..
I did a rebase of the current upstream experimental branch before changing the case.
I'm still very new to git, I hope I did this correctly.

@tux-box tux-box closed this by deleting the head repository Sep 23, 2022
@rautamiekka
Copy link

Lazy evaluation should help performance, too.

@morgoth0
Copy link
Contributor

Lazy evaluation should help performance, too.

Not for this... it is just for linux to recognize files at load time. ARMA itself evaluates everything as lower case anyway no matter what you have it as other than explicit string comparisons

@tux-box
Copy link
Author

tux-box commented Sep 23, 2022

Lazy evaluation should help performance, too.

Not for this... it is just for linux to recognize files at load time. ARMA itself evaluates everything as lower case anyway no matter what you have it as other than explicit string comparisons

I wish I understood Git better, I really do. For some reason copies of everything got pushed when they don't exist locally. I"m starting over.

@tux-box
Copy link
Author

tux-box commented Sep 23, 2022

I redid the whole thing and submitted a new PR.
There were a lot of upstream stuff waiting to be dealt with, I went ahead and merged those before starting.
Figures crossed, I hope I didn't anger someone this time.

@morgoth0
Copy link
Contributor

Seems okay to me, but it is late here ;)

@morgoth0
Copy link
Contributor

morgoth0 commented Sep 23, 2022

But I for one, if the PR is clean, would have zero issues with making this change. Wouldn't cause any issues for Windows server owners and is cleaner for Linux server owners, so win-win

@rautamiekka
Copy link

rautamiekka commented Sep 23, 2022

Lazy evaluation should help performance, too.

Not for this... it is just for linux to recognize files at load time. ARMA itself evaluates everything as lower case anyway no matter what you have it as other than explicit string comparisons

Not for this, true, but overall.

I wish I understood Git better, I really do. For some reason copies of everything got pushed when they don't exist locally. I"m starting over.

Yeah, I already quit trying to understand Git for its backwardness and the "Made a mistake ? That's your problem, no fixing allowed" design mentality.

@tux-box
Copy link
Author

tux-box commented Sep 23, 2022

I probably should have mentioned this sooner, but I started over with PR: #1026
Please post any further comments there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants