Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tasmota blueprint #319

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Conversation

SoloJan
Copy link
Contributor

@SoloJan SoloJan commented Oct 8, 2024

This is a generic blue print to connect with any Tasmota device. Tasmota is very generic firmware, and is used in relays, sensors, powermeters, ledstrips and even MP3 players, and we also use it to control the water purifier. I was therefore not sure in which category to put it.

I tested it on a couple of our Tasmota devices.

I read the contributting_guidelines, and I think that I comply to them, but its my first contribution. So feel free to comment

@nkrasko
Copy link
Member

nkrasko commented Oct 8, 2024

Please find logo here!

tasmota

Copy link
Member

@nikitug nikitug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jan, thank you for the contribution! Also feel free to add Tasmota as a new vendor into vendors.yml.

relays/tasmota/firmware.lua Outdated Show resolved Hide resolved
relays/tasmota/manifest.yml Show resolved Hide resolved
relays/tasmota/manifest.yml Outdated Show resolved Hide resolved
@SoloJan
Copy link
Contributor Author

SoloJan commented Oct 9, 2024

I also added a device in the device.yml i put the status to ready_for_testing, i did test the behavior of the blueprint on several physical devices, but was not sure if you require aditional testing by a third party

@SoloJan SoloJan marked this pull request as ready for review October 9, 2024 12:29
@nikitug
Copy link
Member

nikitug commented Oct 10, 2024

@SoloJan, we have the following verification levels:

Name Description
verified Tested on a real device and quality-checked by Enapter or certified partners.
community_tested Tested by a community member on a real device. Proof of performance was provided to Enapter (screenshots, temporary site access).
ready_for_testing This blueprint has yet to be tested. It may not work as expected.

Please upload the latest version of the blueprint to the real device in Enapter Cloud and send us the link to developers@enapter.com, we will confirm it's tested.

Feel free to change to community_tested level. I think it's good to merge 👍

@SoloJan
Copy link
Contributor Author

SoloJan commented Oct 17, 2024

@nikitug sorry for late reply had some other things on my mind this week. Our live setup is at a customer location, we do use some tasmota devices for example to switch on our waterpurifier when we start the electrolyser but we use a slightly different setup, and I dont want to modify them at this stage just to get this generic blue print to a different state. I can upload it, and test it and then switch back to the old settings, but I dont want to leave it out there in a way that you can check it with a link at a time convenient for you.

I'd say we leave it to ready_for_testing and I might do a nother pull request once I get arround testing it. And feel free to merge it, I dont have the rights to do so

@nikitug nikitug merged commit a97c634 into Enapter:main Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants