Fix build with GCC 13 #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As in previous versions, libstdc++ in GCC 13 has trimmed internal inclusion of standard headers, necessitating their proper inclusion when used: https://gcc.gnu.org/gcc-13/porting_to.html
|
please can we have some progress on merging this, or the other fix for GCC-13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in previous versions, libstdc++ in GCC 13 has trimmed internal inclusion of standard headers, necessitating their proper inclusion when used:
https://gcc.gnu.org/gcc-13/porting_to.html
Note that this is the bare minimum change for this to compile with GCC 13, based on how this header is used internally etc. It is technically more correct to explicitly include this header in every file that uses it, but that is left as an exercise for the reader.