-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DEVELOP pdf space lost with images on sponge PDF template #31456
Open
thersane-john
wants to merge
60
commits into
Dolibarr:develop
Choose a base branch
from
thersane-john:fix_v20_pdf_space_lost_with_images_sponge
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix DEVELOP pdf space lost with images on sponge PDF template #31456
thersane-john
wants to merge
60
commits into
Dolibarr:develop
from
thersane-john:fix_v20_pdf_space_lost_with_images_sponge
+452
−370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v20_pdf_space_lost_with_images
…v20_pdf_space_lost_with_images
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…ace_lost_with_images_eratosthene2
…ix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
thersane-john
changed the title
Fix v20 pdf space lost with images on sponge PDF template
Fix DEVELOP pdf space lost with images on sponge PDF template
Oct 24, 2024
@eldy I have change merge branch from V20 to develop but can you merge Dolibarr V20 into "develop" branch ? That way, I'll be able to handle the PDF conflict later on. |
…ix_v20_pdf_space_lost_with_images
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_eratosthene2
…ane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
…hub.com:thersane-john/dolibarr into fix_v20_pdf_space_lost_with_images_sponge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
NEED PR #31442 to be merged before Or merge this one to merge both