Update change select to button on/off #31443
Conversation
htdocs/user/virtualcard.php
Outdated
| $tmparray['USER_PUBLIC_HIDE_SOCIALNETWORKS_BUSINESS'] = (GETPOST('USER_PUBLIC_HIDE_SOCIALNETWORKS_BUSINESS') ? 1 : 0); | ||
| $tmparray['USER_PUBLIC_MORE'] = (GETPOST('USER_PUBLIC_MORE') ? GETPOST('USER_PUBLIC_MORE') : ''); | ||
|
|
||
| $tmparray['USER_PUBLIC_HIDE_PHOTO'] = (getDolGlobalString('USER_PUBLIC_HIDE_PHOTO') ? 1 : 0); |
There was a problem hiding this comment.
Because all option ate now set by ajax, we don't need any more this part of cor. Except for the "note". For it, we can keep old code to have the note saved from the user choice (so using GETPOST).
There was a problem hiding this comment.
ok i fix it and i complete the process
eldy
added
the
PR to fix or conflict to solve
htdocs/core/lib/functions.lib.php
Outdated
| /** | ||
| * Get socal network for user or societe | ||
| * @param int $userId user Id | ||
| * @return int|array -1 if KO, array if OK |
There was a problem hiding this comment.
array<array{name:string,url:string}>|int<-1,-1> is better/needed.
There was a problem hiding this comment.
It looks like the type of the User class also needs an update
User::$socialnetworks
htdocs/core/lib/functions.lib.php
Outdated
| @@ -14850,3 +14850,42 @@ function recordNotFound($message = '', $printheader = 1, $printfooter = 1, $show | |||
| } | |||
| exit(0); | |||
| } | |||
|
|
|||
| /** | |||
| * Get socal network for user or societe | |||
There was a problem hiding this comment.
Small typo to fix: 'social'
| @@ -341,11 +341,15 @@ | |||
| } | |||
|
|
|||
| // Social networks | |||
| if (empty($object->socialnetworks)) { | |||
There was a problem hiding this comment.
if the array $object->socialnetworks is empty then getSocialNetworks($object->id) will return empty too. Because $object->socialnetworks is loaded by the fetch of user the same way the getSocialNetworks do it. So i on't understand the need of line 345.
If there is at least one social network in $object->socialnetwork then we can show the option to each of them to on or off
NEW|New update in virtual card for user by changing select yes/no to button on/off