FIX : Fix SQL request for fix duplicate accounting account and remove wrong and obsolete SQL request who break the accounting account when we launch repair with multi-entities #31438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wrong and obsolete SQL request who break the accounting account when we launch repair with multi-entities
kkhelifa-opendsi
added a commit
to Easya-Solutions/dolibarr
that referenced
this pull request
Oct 17, 2024
… wrong and obsolete SQL request who break the accounting account when we launch repair with multi-entities PR Dolibarr#31438
eldy
reviewed
Oct 19, 2024
| AND aa.rowid != aad.min; | ||
| -- SELECT * from tmp_llx_accouting_account; | ||
| -- If there is record in tmp_llx_accouting_account, make a look on each line to do | ||
| UPDATE llx_facturedet AS t LEFT JOIN tmp_llx_accouting_account AS taa ON taa.rowid = t.fk_code_ventilation SET t.fk_code_ventilation = taa.min WHERE taa.rowid IS NOT NULL; |
There was a problem hiding this comment.
I am not sure this kind of syntax Update xxx left join yyy is standard sql accepted by pgsql. Did you test it in postgres ?
There was a problem hiding this comment.
it's in /mysql/migration/repair.sql so is it not executed only for mysql ?
There was a problem hiding this comment.
I'm afraid no, it is common to all databases.
Mysql is the database to use for main sql code (so contains allnpart common) and other dir for specific. Repair is currently common so found into the mysql dir.
Does this patch is not enough ?
d9d0618
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SQL request for fix duplicate accounting account and remove wrong and obsolete SQL request who break the accounting account when we launch repair with multi-entities