Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Correction of new hook PR #31422

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

atm-lucasmantegari
Copy link
Contributor

FIX - Correction of new hook PR

This PR corrects the PR for adding a new hook. I made the mistake of setting the text_info replacement to $reshook == 0, which is the default value for reshook, which always replaced the given with empty when the hook was not in use.

@@ -2573,7 +2573,7 @@
if ($reshook == 1) {
// for add information
$text_info .= $hookmanager->resPrint;
} elseif ($reshook == 0) {
Copy link
Member

@eldy eldy Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i made an error by validating a new hook into an already released branch. i revert it.
You can submit the hook into develop branch.
Also the fix is not correct. We should have


if ($reshook == 1) {   // We replace
						// for add information
						$text_info = $hookmanager->resPrint;
} elseif ($reshook == 0) {     // default action, we add if there is something to add
						$text_info .= $hookmanager->resPrint;

@eldy eldy added the PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants