-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admonition Customization tutorial #32
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @dillp1!
If you find my review helpful, please apply it to PR-wide (e.g., Change all tables to Markdown). You might also want to run a quick spell check on the document!
⚡ Successfully deployed to Cloudflare Pages!| 🔨 Latest commit | 9b2e29e | |
Co-authored-by: 정보현 Bohyun Jung <orange.b.jung@gmail.com>
Co-authored-by: 정보현 Bohyun Jung <orange.b.jung@gmail.com>
Co-authored-by: 정보현 Bohyun Jung <orange.b.jung@gmail.com>
I made some great changes and finally added that diagram (don't call me a graphic designer... I tried my best haha) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for applying the suggestions.
Before the merge, I noticed a mix of comma-separated and comma-less syntax for HTML rgb / rgba representations. Both work in modern browsers, but it'd be better if we stick to one style;
- I see another in-project page has comma-separated expressions.
- However, surprisingly, according to the MDN document, comma-less expression is standard, while comma-separated is legacy.
@dillp1 @homotechsual What's your opinion on which one to adopt?
I've always used comma-separated expressions in my experience coding with Java, C, and Python. Ultimately, I think @homotechsual has a bit more experience than me and could give a more technical answer, but I would use comma-separated based on my experience. |
Definitely comma separated imo. |
So basically if you can standardise the |
@dillp1 Can you make another commit to make them all comma-separated? Let's get these merged! |
@bohyunjung will do when I’m free tomorrow! 😁 |
Updated content to be more consistent with color values! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 LGTM!
@homotechsual Waiting for your approval and merge :) |
This PR is set to add an admonition customization tutorial. The tutorial is aimed at beginners who have little or no prior CSS or HTML experience. The tutorial guides the user through the HTML using Inspect, and teaches them how to edit the simple CSS of Docusaurus to edit any html element.
Constructive feedback is appreciated for the clarity and correctness of the tutorial. I would be more than happy to add or change any content!