Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add avatar component by Docux #29

Closed
wants to merge 4 commits into from
Closed

Add avatar component by Docux #29

wants to merge 4 commits into from

Conversation

Juniors017
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

⚠️ Deployments require the '🚀request-deploy' label

This repository is a forked repository. For security reasons, deployments from forked repositories are not automatic.

To request a deployment, add the '🚀request-deploy' label to this pull request. (Only some members can add labels).

homotechsual
homotechsual requested changes Jul 21, 2024
View reviewed changes
docs/component-library/new/Simplecard/index.mdx Show resolved Hide resolved
src/components/Avatar/AvatarContainer/index.tsx Outdated
className,
avatarPosition
)}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

src/components/Avatar/AvatarContainer/index.tsx Outdated
)}

style={style}>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

src/components/Avatar/AvatarImage/index.tsx Outdated Show resolved Hide resolved
src/components/Avatar/AvatarImage/index.tsx Outdated Show resolved Hide resolved
src/components/Avatar/AvatarImage/index.tsx Outdated
src={generatedAvatarUrl}
alt={alt}
title={title}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@Juniors017
Copy link
Contributor Author

Hi @homotechsual
I don t know why card componant was modificated.. it s old 😔
Sorry

Juniors017
Juniors017 commented Jul 22, 2024
View reviewed changes
Copy link
Contributor Author

@Juniors017 Juniors017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@homotechsual
Copy link
Collaborator

Can you push a commit to revert the change to SimpleCard in this PR. I cannot merge this with that change in place.

@homotechsual
Copy link
Collaborator

Sorry but this now deletes the SimpleCard file rather than leaving it unchanged. This would break the SimpleCard demo/example.

@Juniors017 Juniors017 closed this Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homotechsual homotechsual homotechsual requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Juniors017 @homotechsual