-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Budget App V 1.0 #23
Budget App V 1.0 #23
Conversation
Feat/setup project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations!
Highlights
- No linter errors ✔️
- Repo looks professional 💼
- Solid pull request scroll
- Good quality commits
- Good job !! 👏 👏 👏
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Implemented Features:
Dear code reviewer: If you would like to review my project by Branches you can do it on the closed pull request section where you can find a brief description for what I've done in each branch.
Project Budget-app
Set up environment
Validate all user input(forms) to make sure that anyone with bad intentions cannot compromise your app
Data is private for current_user
Set up models according to the ERD Diagram.
Implement the authentication and authorization.(
sing up and log in pages
)Create the Page to add a category
Splash screen
Home Page (
categories page
)Add a new Transaction page
transactions page
(will display all transactions)Add a new category page
Fix N+1 problems
Implement Styling
#3778c2
rgb: (55, 120, 194) taiilwind(closeste one blue-500)#5fb523
, in tailwind coudl begreen-600
#434b54
, in tailwind coul be:slate-600
Review Tests and implement any pending test
Add a new category
pageDeploy your Project
Document Your Project