Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaris midi fix #2041

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Conversation

Solaris7518
Copy link
Contributor

@Solaris7518 Solaris7518 commented Oct 24, 2024

About the PR

Fixes midis as they were broken by a change from upstream.

Why / Balance

A recent change from upstream (Addition of a new instrument) caused almost every midi that players use to not sound as they did before the change.

Technical details

Reverts a file to a previous version, comments out a change.

Media

N/A

Requirements

Breaking changes

N/A

Changelog

🆑
  • fix: Fixed almost every midi being completely ruined by a recent change from upstream. You're welcome, my fellow musicians.

Signed-off-by: Solaris <63768197+Solaris7518@users.noreply.github.com>
@Radezolid
Copy link
Contributor

If you want it to close the issue on merge you can add fixes #2040

@deltanedas deltanedas merged commit ae963ba into DeltaV-Station:master Oct 24, 2024
13 checks passed
@Solaris7518 Solaris7518 deleted the Solaris-Midi-Fix branch October 25, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants