Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklist nukedisk from slime storage #2002

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

MilonPL
Copy link
Contributor

@MilonPL MilonPL commented Oct 13, 2024

About the PR

what it says on the tin

Why / Balance

bug fix, you can't access storage when the target cryos so if the captain has the nuke disk there it will get sent to nullspace

Breaking changes

Changelog

no cl because i can't come up with a good one

@MilonPL MilonPL requested a review from a team as a code owner October 13, 2024 19:10
@deltanedas
Copy link
Member

same applies to hypospray etc
it should just be listed like hands and inventory are

@MilonPL
Copy link
Contributor Author

MilonPL commented Oct 13, 2024

same applies to hypospray etc it should just be listed like hands and inventory are

that's the ideal long term solution but probably upstream, this is a quick fix so that it's not literally gamebreaking

@deltanedas
Copy link
Member

would also have to be done for rodentia storage i imagine

@MilonPL
Copy link
Contributor Author

MilonPL commented Oct 13, 2024

would also have to be done for rodentia storage i imagine

you're right yeah i forgot that was a thing

@deltanedas deltanedas enabled auto-merge (squash) October 13, 2024 19:46
@deltanedas deltanedas enabled auto-merge (squash) October 13, 2024 19:46
@deltanedas deltanedas merged commit a2cde26 into DeltaV-Station:master Oct 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants