Trait addition: Alcoholic, German, Stutter #88
Conversation
… and siezures), German (accent trait), and Stutter (minor version of built-in shutter)
| private static readonly IReadOnlyDictionary<string, string> SpecialWords = new Dictionary<string, string>() | ||
| { | ||
| { "yeah", "ja" }, | ||
| { "yes", "ja" }, | ||
| { "thank you", "danke" }, | ||
| { "thanks", "danke" }, | ||
| { "shit", "sheiße" }, | ||
| { "damned", "verdammt" }, | ||
| { "fucking", "verdammt" }, | ||
| { "fucked", "gefickt" }, | ||
| { "hello", "guten tag" }, | ||
| { "bye", "tschüss" }, | ||
| { "goodbye", "auf viedersehen" }, | ||
| { "hell", "hölle" }, | ||
| { "please", "bitte" }, | ||
| { "true", "stimmt" }, | ||
| { "my god", "mein gott" }, | ||
| }; |
There was a problem hiding this comment.
I believe there's a system for doing this which uses locale
There was a problem hiding this comment.
I'll look into this! This system is based off of the skeleton's accent system, which replaces words in a pretty similar way. I didn't see locale used anywhere in the existing accent components, but I will go ahead and search that down <3
There was a problem hiding this comment.
Any recollection of where I might find the locale-based system? I'm not finding anything in my solution or on the discords, but that doesn't mean it isn't there.
|
|
||
| if (!_timing.IsFirstTimePredicted) | ||
| return; | ||
| foreach(var player in _player.GetAllPlayerData()) |
There was a problem hiding this comment.
use a query for this traits component
There was a problem hiding this comment.
I'm assuming this is AllEntityQuery? I had no idea this was a thing, thank you! I'll go ahead and switch this over. I'm assuming that this will query entities other than players, which would make it slightly more expensive but also allow it to be used universally, and that sounds good.
There was a problem hiding this comment.
There's a function for component queries, EntitySystem's EntityQueryEnumerator
There was a problem hiding this comment.
What's the functional difference between AllEntityQuery and simply EntityQuery? Neither of them have code summaries, though I spose I could go check how they were written to try n figure it out
There was a problem hiding this comment.
this should be made into a generic addiction system
There was a problem hiding this comment.
Are you thinking just changing this to apply to any chemicals in the chemstream, rather than just ethanol? Unfortunately, while we discussed adding tobacco/marijuana dependency, currently cigarettes are purely cosmetic and don't add to the chemstream.
There was a problem hiding this comment.
I think cigarettes do add to the chemstream, the effects are just really weak and the amount of reagent is so low it gets processed immediately. I don't know how else the Syndicate Smokes would work.
There was a problem hiding this comment.
Syndicate cigarettes and other smokables with chems injected into them can be used to metabolise reagents, but nicotine itself does not exist as a reagent yet, and thus most cigarettes are useless. Nonetheless, a generic addiction system would certainly open possibilities for nicotine, desoxyephedrine, and perhaps other chemicals to pose a minor long-term liability to the station crew and medical department.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Closing as stale |
About the PR
Adds three traits to the trait system. Some changes made to traits.ftl and disabilities.yml that may conflict with other changes.
Media
Changelog
🆑