Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split processing and default preprocesisng params into separate files #1994

Conversation

BloodAxe
Copy link
Collaborator

@BloodAxe BloodAxe commented May 16, 2024

This PR contains some groundwork for YoloNAS-R:

  1. Moves all default preprocessing params to separate file in order to make processing.py smaller and also allow introduction of OBB Processings to be in separate file (Existing structure forces us to have all processing and default preprocessing params in a single file)
  2. ClassBalancedSampler not has shuffle attribute (Not used, exists for compatibility with dataloaders.get since they forward this attr to sampler)
  3. Adds _shift_bboxes_cxcywhr helper function

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

Copy link
Collaborator

@shaydeci shaydeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ofrimasad ofrimasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 86cbee3 into feature/SG-1488-YoloNAS-R-integration May 17, 2024
3 of 4 checks passed
@BloodAxe BloodAxe deleted the feature/SG-1488-YoloNAS-R-integration-some-groundwork branch May 17, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants