[CI] Enable Fastify suite.js

[watson]

No description provided.

[watson]

• [CI] Enable Fastify suite.js #4771 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @watson and the rest of your teammates on Graphite

[github-actions]

Overall package size

Self size: 7.46 MB
Deduped: 63.23 MB
No deduping: 63.51 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.59 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 9.0.0 | 580.4 kB | 1.03 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

[pr-commenter]

Benchmarks

Benchmark execution time: 2024-10-12 06:40:30

Comparing candidate commit ee21cfc in PR branch watson/10-11-remove_un-used_file with baseline commit bd4aff5 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

[rochdev]

This looks like something we'd want to be enabled 🤔 Does it still error if uncommented?

[watson]

@rochdev I assume the way you'd test it is by running this command?

PLUGINS="fastify" yarn test:plugins:upstream

If that's the case, then it actually does pass with the following output after running it:

yarn run v1.22.22
$ node ./packages/dd-trace/test/plugins/suite.js
08:29:29 ❯ npm view fastify dist-tags --json
08:29:30 ❯ git clone https://github.com/fastify/fastify.git --branch v5.0.0-alpha.1 --single-branch /var/folders/bz/8vjzx43955l4p8nr7f08hhsw0000gp/T/dd-trace-js-suites-VU5Vyt
08:29:31 ❯ npm install --legacy-peer-deps
08:30:04 ❯ NODE_OPTIONS='-r /Users/thomas.watson/go/src/github.com/DataDog/node_modules/dd-trace/init' node_modules/.bin/tap -J test/*.test.js test/*/*.test.js --no-coverage --no-check-coverage
08:30:04 ❯ rm -rf /var/folders/bz/8vjzx43955l4p8nr7f08hhsw0000gp/T/dd-trace-js-suites-8R0cOm
08:30:04 ❯ node_modules/.bin/tap -J test/*.test.js test/*/*.test.js --no-coverage --no-check-coverage
✨  Done in 34.83s.

I'll update the PR...

[watson]

I can see that the suite.js file was added by @bengl in the commented out state (#1331). So it has never been enabled. I assume it was just a mistake back then 🤷