Merge Dev into Main #111
Merged
Merge Dev into Main #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge main into dev
Bumps [splink](https://github.com/moj-analytical-services/splink) from 3.9.15 to 4.0.0. - [Release notes](https://github.com/moj-analytical-services/splink/releases) - [Changelog](https://github.com/moj-analytical-services/splink/blob/master/CHANGELOG.md) - [Commits](moj-analytical-services/splink@v3.9.15...v4.0.0) --- updated-dependencies: - dependency-name: splink dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Update README.md to include SBOM excerpt
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Add Numeral Normalization to DedupliFHIR Parsing
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Bump splink from 3.9.15 to 4.0.0
IsaacMilarky
requested review from
decause-gov,
natalialuzuriaga and
patsier-cms
IsaacMilarky
added
enhancement
decause-gov
reviewed
Aug 1, 2024
| @@ -7,7 +7,7 @@ authors = ["Pat Sier <patrick.sier@cms.hhs.gov>", | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.10" | |||
| splink = "^3.9.15" | |||
| splink = "^4.0.0" | |||
The tests pass on this PR and it works when I run it on test data. What is blocking for approval? |
Nothing :) #Shipit 🚢 |
patsier-cms
approved these changes
Aug 2, 2024
|
Nothing, ship it 🚢 :)
Remy DeCausemaker
Open Source Lead
Digital Service at CMS.gov
…________________________________
From: Isaac Milarsky ***@***.***>
Sent: Thursday, August 1, 2024 5:54:01 PM
To: DSACMS/dedupliFHIR ***@***.***>
Cc: DeCausemaker, Remy (CMS/DSAC) ***@***.***>; Review requested ***@***.***>
Subject: Re: [DSACMS/dedupliFHIR] Merge Dev into Main (PR #111)
I reckon the missing docstring for the qrda check is ok since it's not implemented yet, and I can't say whether the Splink version bumps work or not, but I don't see anything obviously blocking in there, so, LGTM +1 🚢 ➿
The tests pass on this PR and it works when I run it on test data. What is blocking for approval?
—
Reply to this email directly, view it on GitHub<#111 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZXUXUPPFSPAD3MGNJ4RHHTZPKU7TAVCNFSM6AAAAABL3LPIRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRUGA3TMOJRG4>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Dev into Main
Result
Merge Dev into Main to Push Recent Changes into Production
Changes:
Closes #55
Test Plan
make test