-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Dev into Main #111
Merge Dev into Main #111
Conversation
Merge main into dev
Bumps [splink](https://github.com/moj-analytical-services/splink) from 3.9.15 to 4.0.0. - [Release notes](https://github.com/moj-analytical-services/splink/releases) - [Changelog](https://github.com/moj-analytical-services/splink/blob/master/CHANGELOG.md) - [Commits](moj-analytical-services/splink@v3.9.15...v4.0.0) --- updated-dependencies: - dependency-name: splink dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Update README.md to include SBOM excerpt
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Add Numeral Normalization to DedupliFHIR Parsing
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Bump splink from 3.9.15 to 4.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon the missing docstring for the qrda check is ok since it's not implemented yet, and I can't say whether the Splink version bumps work or not, but I don't see anything obviously blocking in there, so, LGTM +1 🚢 ➿
@@ -7,7 +7,7 @@ authors = ["Pat Sier <patrick.sier@cms.hhs.gov>", | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.10" | |||
splink = "^3.9.15" | |||
splink = "^4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major release! Nice!
The tests pass on this PR and it works when I run it on test data. What is blocking for approval? |
Nothing :) #Shipit 🚢 |
Nothing, ship it 🚢 :)
Remy DeCausemaker
Open Source Lead
Digital Service at CMS.gov
…________________________________
From: Isaac Milarsky ***@***.***>
Sent: Thursday, August 1, 2024 5:54:01 PM
To: DSACMS/dedupliFHIR ***@***.***>
Cc: DeCausemaker, Remy (CMS/DSAC) ***@***.***>; Review requested ***@***.***>
Subject: Re: [DSACMS/dedupliFHIR] Merge Dev into Main (PR #111)
I reckon the missing docstring for the qrda check is ok since it's not implemented yet, and I can't say whether the Splink version bumps work or not, but I don't see anything obviously blocking in there, so, LGTM +1 🚢 ➿
The tests pass on this PR and it works when I run it on test data. What is blocking for approval?
—
Reply to this email directly, view it on GitHub<#111 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZXUXUPPFSPAD3MGNJ4RHHTZPKU7TAVCNFSM6AAAAABL3LPIRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRUGA3TMOJRG4>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Merge Dev into Main
Result
Merge Dev into Main to Push Recent Changes into Production
Changes:
Closes #55
Test Plan
make test