-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(route/nytimes): enhance full text fetch #17292
Draft
dzx-dzx
wants to merge
3
commits into
DIYgod:master
Choose a base branch
from
dzx-dzx:nytimes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
}); | ||
await page.goto(link, { | ||
waitUntil: 'domcontentloaded', | ||
if (request.url().includes('https://www.nytimes.com/svc/onsite-messaging/query') || request.url().includes('https://meter-svc.nytimes.com/meter.js')) { |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High
' ' can be anywhere in the URL, and arbitrary hosts may come before or after it.
https://www.nytimes.com/svc/onsite-messaging/query
Error loading related location
Loading
github-actions
bot
added
the
Auto: Route Test Complete
Auto route test has finished on given PR
label
Oct 24, 2024
Successfully generated as following: http://localhost:1200/nytimes/en - Success ✔️<?xml version="1.0" encoding="UTF-8"?>
<rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0">
<channel>
<title>纽约时报中文网 - 英文原版</title>
<link>https://cn.nytimes.com</link>
<atom:link href="http://localhost:1200/nytimes/en" rel="self" type="application/rss+xml"></atom:link>
<description>纽约时报中文网 - 英文原版 - Powered by RSSHub</description>
<generator>RSSHub</generator>
<webMaster>contact@rsshub.app (RSSHub)</webMaster>
<language>en</language>
<lastBuildDate>Thu, 24 Oct 2024 17:34:11 GMT</lastBuildDate>
<ttl>5</ttl>
<item>
<title>「英」</title>
<description></description>
<link>https://www.nytimes.com/2024/10/23/world/asia/modi-xi-putin-brics.html</link>
<guid isPermaLink="false">https://www.nytimes.com/2024/10/23/world/asia/modi-xi-putin-brics.html</guid>
<pubDate>Thu, 24 Oct 2024 04:46:24 GMT</pubDate>
</item>
<item>
<title>「英」iPhone为何中国制造?</title>
<description></description>
<link />
<guid isPermaLink="false">「英」iPhone为何中国制造?</guid>
<pubDate>Thu, 24 Oct 2024 02:36:02 GMT</pubDate>
</item>
<item>
<title>「英」</title>
<description></description>
<link>https://www.nytimes.com/2024/10/13/upshot/trump-black-hispanic-voters-harris.html</link>
<guid isPermaLink="false">https://www.nytimes.com/2024/10/13/upshot/trump-black-hispanic-voters-harris.html</guid>
<pubDate>Wed, 23 Oct 2024 20:36:19 GMT</pubDate>
</item>
</channel>
</rss> |
Successfully generated as following: http://localhost:1200/nytimes/en - Failed ❌
|
Successfully generated as following: http://localhost:1200/nytimes/en - Failed ❌
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Involved Issue / 该 PR 相关 Issue
Close #
Example for the Proposed Route(s) / 路由地址示例
New RSS Route Checklist / 新 RSS 路由检查表
Puppeteer
Note / 说明