Bugfix in TestArithmeticalDSSOnSurfels

[troussil]

PR Description

The main issue was an iterator dereferencing in the init method of the class ArithmeticalDSSOnSurfels. This was done because of a bad algorithmic choice: in short, the new point to process was computed by looking at the next surfel, instead of looking at the orientation of the current surfel. Several parts of the class has been rewritten to use the latter strategy, which nicely fixes the bug.

In summary, in this new version:

• no *myEnd in the unit method,
• for each surfel, an associated point is extracted based on its orientation.

In addition, the template non-type adjacency has been removed, since one always wants to use "standard" digital straight segment and "4"-connectivity in the use-case targeted by the class.

Checklist

(the three first entries are not relevant since it is a bug fix, but I will take care of the other ones)

• Unit-test of your feature with Catch.
• Doxygen documentation of the code completed (classes, methods, types, members...)
• Documentation module page added or updated.
• New entry in the ChangeLog.md added.
• No warning raised in Debug mode.
• All continuous integration tests pass (Github Actions)

[kerautret]

Looks fine just some minor edits, and have a look to the template change on the example compilation (exampleMaximalSegmentSliceEstimation.cpp) (and see log https://github.com/DGtal-team/DGtal/actions/runs/10813115621/job/29996362923?pr=1742)

[kerautret]

👌🏻

[kerautret]

Just a renaming aLine doxygen

[kerautret]

Fine for me thanks @troussil could merge when last CI build is done

[dcoeurjo]

👌