Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P-convexity: another characterisation of full convexity #1736

Merged
merged 17 commits into from
Aug 6, 2024

Conversation

JacquesOlivierLachaud
Copy link
Member

@JacquesOlivierLachaud JacquesOlivierLachaud commented Jun 28, 2024

PR Description

This PR provides an implementation of P-convexity, which is a recursive equivalent definition of full convexity. It is shown that it provides a faster way to compute full convexity than its morphological characterisation.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

Copy link

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1736/index.html

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

Copy link

github-actions bot commented Jul 9, 2024

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1736/index.html

@JacquesOlivierLachaud
Copy link
Member Author

/builddoc

Copy link

github-actions bot commented Jul 9, 2024

The documentation is built. It will be available, after a few minutes, here: https://dgtal-team.github.io/doc-pr/pr1736/index.html

@dcoeurjo dcoeurjo self-requested a review July 10, 2024 16:17
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions. Nice PR

ChangeLog.md Outdated Show resolved Hide resolved
examples/geometry/volumes/pConvexity-benchmark.cpp Outdated Show resolved Hide resolved
src/DGtal/geometry/doc/moduleDigitalConvexity.dox Outdated Show resolved Hide resolved
src/DGtal/geometry/doc/moduleDigitalConvexity.dox Outdated Show resolved Hide resolved
src/DGtal/geometry/doc/moduleDigitalConvexity.dox Outdated Show resolved Hide resolved
src/DGtal/geometry/doc/moduleDigitalConvexity.dox Outdated Show resolved Hide resolved
src/DGtal/geometry/doc/moduleDigitalConvexity.dox Outdated Show resolved Hide resolved
@dcoeurjo
Copy link
Member

hi @JacquesOlivierLachaud there is still a couple of requests for this pr

@JacquesOlivierLachaud
Copy link
Member Author

Should be good now !

@dcoeurjo dcoeurjo self-requested a review August 6, 2024 12:59
@dcoeurjo dcoeurjo merged commit cc6e213 into DGtal-team:master Aug 6, 2024
10 checks passed
@dcoeurjo dcoeurjo deleted the PConvexity branch August 6, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants