Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh remove isolated vertex #1709

Merged
merged 15 commits into from
Nov 16, 2023
Merged

Mesh remove isolated vertex #1709

merged 15 commits into from
Nov 16, 2023

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Nov 9, 2023

PR Description

By default the Meshreader imports all vertex even if they are not associated to a face. This PR adds a method to remove them that allows to avoid errors when applying conversion to a SurfaceMesh for instance. It also include a read improvement to ignore path when the material path is wrong and load by default from the current path.

Checklist

  • Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

@kerautret kerautret changed the title Mesh cleaner method Mesh remove isolated vertex Nov 11, 2023
Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just minor comment

src/DGtal/shapes/Mesh.ih Outdated Show resolved Hide resolved
@kerautret
Copy link
Member Author

thanks @dcoeurjo just done, but perhaps DGtalTools will failed from the renaming I will do it afterwards

@kerautret kerautret mentioned this pull request Nov 13, 2023
7 tasks
@kerautret
Copy link
Member Author

Done small PR in DGtalTools : DGtal-team/DGtalTools#453 that need to be merged before

@dcoeurjo dcoeurjo merged commit 85e0277 into DGtal-team:master Nov 16, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants