Add distance and value info to buildingplan item selection list #4312 #4956
Conversation
frogi16
commented
Sep 22, 2024
frogi16
commented
- add option to sort by value
- reorder sorting options to match ordering of colums
- adjust width of existing columns
|
FYI: @myk002, @phooenixdassmatte EDIT: I just thought that some items might have the same name but differ in value because of values of material used to enhance the items (just compare sapphires to agats...). Tomorrow I will test what happens in such situation when my solution is applied, because it's possible the items are lumped together despite having different values. |
Hey there! Looks good, and still gives more information than vanilla. I have no idea how df code works but an idea to include the encrusted object in the name? That way it would be a separate line of: +<<brass chain>>+ enhanced with +polished diamond+ And would also give more information. We have big screens now so the added text would fit, but could maybe become problematic if it is encrusted several times haha. :D |
|
I managed to ungroup items with different values quite easily @myk002 I would be grateful for code review. |
|
Ok, now that the craziness of the 50.14 release is behind us, I can catch up on code reviews. Thank you for your patience. |
…k#4312 - adjust width of existing columns - reorder sorting options to match ordering of colums
- save item name (desc) in dictionary items instead of using keys for this purpose - encode item value in dictionary key, this way ungrouping items with different values
|
@myk002 I made post-review changes, please review and merge if everything is fine. I tested it quickly and seems OK. Force pull mentioned by Github is just me rebasing on top of new changes from official repo, I will try to do it cleaner next time with separate branch. |
|
yeah, try not to rebase while the review is active since it causes all the comments to get lost and I lose the ability to see what's changed since the last review. Merging in from upstream is fine, though! |
|
when you have a minute, could you add your name to https://github.com/DFHack/dfhack/blob/develop/docs/about/Authors.rst ? |
