Blueprint.cpp: Use cuboid class, small changes #4926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use cuboid class * fix unintentional copies in iters * check start.isValid() instead of start.x * clarify when no file is created
myk002
reviewed
Sep 28, 2024
|
Commit history turned into a mess, so I remade it as PR #4974. Would've just suggested a squash and merge, but Github was showing the 47 file changes from syncing, for whatever reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
blueprint.cppto useDFHack::cuboid. Uncertain about how this impacts performance (w/r/tstd::mapinsertions) since tile iteration is now in a different order.Also added a message when no files are created instead of
Generated blueprint file(s):followed by nothing.