Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spellmasons Module #930

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add Spellmasons Module #930

wants to merge 6 commits into from

Conversation

Chain-BC
Copy link

@Chain-BC Chain-BC commented Aug 7, 2024

Spellmasons dedicated server module partly based on the existing nodejs module, as it requires node to host the server.

Just changing the default for "Custom Version" to the release candidate, not exact version but it works with the newest non-beta release.
@Chain-BC
Copy link
Author

A bit of context as to why I did some things the way I did. Currently Spellmasons servers do not store any data (any game is saved on the client side) hence why the whole game folder is deleted when updated. I also am just a bit inexperienced with this kind of stuff, so that is part of the reason as well. Also, the only way to get the server is to build it from the GitHub repository or possibly get it through docker, but I haven't used docker very much so I opted for GitHub instead. If the module needs work and needs a rewrite do let me know, I will close the pull request or make it a draft, any feedback would be appreciated as well. If someone else wants to write a better one, that is fine too.

@IceOfWraith
Copy link
Collaborator

I'm not familiar with this game, so haven't looked too closely yet. I'll try to get to it this week.

@Greelan
Copy link
Collaborator

Greelan commented Aug 13, 2024

Has this been tested on Windows? cp is not a Windows command

@Chain-BC
Copy link
Author

Chain-BC commented Aug 13, 2024

I tested it on Windows and Linux, and both worked just fine but perhaps it may be missing some file needed for modding, I am double checking and rewriting what I need to rewrite so I'll make sure it works. I got the command for building the server directly from the package.json in the source files, but it may have been intended to be used on powershell, so I will use that instead.

Now updates do not require downloading the whole repository to be downloaded. Some commands have been shortened for readability and and tested on both Windows and Linux to work. It was not a completely clean install of Windows nor Linux so someone else may need to test the module to see if any problems may come up.
Now it the module should be able to get all the newest releases with no problem, even if the local copy of the repository is outdated.
@Chain-BC
Copy link
Author

Any update on this? I should have gotten it to work on Windows with no problems now but I may have missed something.

@IceOfWraith
Copy link
Collaborator

What's the reasoning behind pulling a specific version by default versus getting the latest?

@Chain-BC
Copy link
Author

I haven't figured out how I should do this yet, but currently the latest version tends to be the beta version which you have to opt-in for on steam. So my reasoning is pull the specific latest stable by default instead of latest beta, since most people won't be using the beta version. A bit of a hassle but I can't think of another way to do it.

@IceOfWraith
Copy link
Collaborator

Okay, that makes sense. Kind of a pain but nothing you can control.

A new stable version was released recently, so changing spellmasonsconfig.json to reflect this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants