Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended python extension and inoffensive settings for vscode/vscodium #4806

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

aapeliv
Copy link
Member

@aapeliv aapeliv commented Sep 15, 2024

No description provided.

Copy link

vercel bot commented Sep 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Sep 15, 2024 11:53pm

"recommendations": [
"dbaeumer.vscode-eslint",
"esbenp.prettier-vscode",
"charliermarsh.ruff"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you use VSCode for Python?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, maybe I should add that? I kind of thought it was installed by default.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah just I know people tend to use other IDEs for Python so wanted to make sure you knew this would only work for VSCode :).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait add what?

Comment on lines +13 to +17
"[python]": {
"editor.tabSize": 4,
"editor.rulers": [
120
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better place for this might be the linting rules? Since this will only enforce with VSCode, you could have the situation where people have different settings in different IDEs, better have it be repo-wide.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is enforced by the linter, but just makes it nicer when in VScode, in particular the ruler

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or rather whatever Prettier is for python, haha. It's more formatting than linting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ideas
Development

Successfully merging this pull request may close these issues.

2 participants