Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump go version #421

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix: bump go version #421

merged 3 commits into from
Apr 30, 2024

Conversation

Scartiloffista
Copy link
Collaborator

Description

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • Linter passes correctly
  • Add tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Does this introduce a breaking change?

  • Yes
  • No

Further comments

Copy link

render bot commented Apr 4, 2024

@mga-chka
Copy link
Collaborator

@Scartiloffista when do you plan to continue the PR?

@Scartiloffista
Copy link
Collaborator Author

@mga-chka, sorry, i forgot about this one. honestly idk, i thought it would have been just a version bump but there are quite some failing parts. i'll try to make space in my workload

@mga-chka mga-chka added the wip label Apr 25, 2024
@Scartiloffista Scartiloffista marked this pull request as ready for review April 29, 2024 14:47
Copy link
Collaborator

@vfoucault vfoucault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Scartiloffista Scartiloffista merged commit be6424f into master Apr 30, 2024
5 checks passed
@vfoucault vfoucault deleted the bump_go_version branch April 30, 2024 08:06
@vfoucault vfoucault removed the wip label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants