added EAC link in edit mode #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmeinhold
requested changes
Aug 25, 2021
profiles/templates/profile.html
Outdated
| @@ -159,6 +159,9 @@ <h2 style="display: inline; color: #00aced;"> | |||
| <input type="text" class="form-control form-control-sm" id="user-twitter" value="{{ member_info.user_obj.twitterName }}" placeholder="Twitter Username"> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <div class="form-group user-form-input">Note: to change external accounts' access, like GitHub, use <a href="https://eac.csh.rit.edu">EAC</a>.</div> | |||
There was a problem hiding this comment.
Hmm, maybe we should list out what eac provides? Not sure if that's necessary.
Also I would drop "access", you need to go to eac to get those accounts to show up at all.
There was a problem hiding this comment.
Afaik, profiles only shows when a user adds a GitHub account on EAC, so I think putting the others in would be unnecessary, but I'll change the language a little bit.
|
Also, I can't see what pylint logs right now, but somehow this failed pylint? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #96
Adds link below the fields relating to finding a user elsewhere on the internet when in edit mode.