Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeISAAC_AO_BUG_FIX flag has no effect #120

Open
psychocoderHPC opened this issue Nov 6, 2020 · 0 comments
Open

CMakeISAAC_AO_BUG_FIX flag has no effect #120

psychocoderHPC opened this issue Nov 6, 2020 · 0 comments
Assignees
@PrometheusPi
Labels
bug
Milestone
version 1.6.0

Comments

@psychocoderHPC
Copy link
Member

The newly introduced CMake flag ISAAC_AO_BUG_FIX introduced in #112 is not given to the compiler and therefore ambient occlusion is still broken.

see: https://github.com/ComputationalRadiationPhysics/isaac/pull/112/files#r518781765

The define must be added via cmake target compile definitions.
@psychocoderHPC psychocoderHPC added this to the version 1.6.0 milestone Nov 6, 2020
@psychocoderHPC psychocoderHPC mentioned this issue Nov 6, 2020
Closed
@psychocoderHPC psychocoderHPC changed the title CMake flag has no effect CMakeISAAC_AO_BUG_FIX flag has no effect Nov 6, 2020
@PrometheusPi PrometheusPi self-assigned this Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PrometheusPi PrometheusPi

Labels
bug
Projects
None yet
Milestone
version 1.6.0
Development

No branches or pull requests
2 participants
@psychocoderHPC @PrometheusPi