Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AO bug via pre-compiler flag broken #119

Closed
psychocoderHPC opened this issue Nov 6, 2020 · 1 comment
Closed

AO bug via pre-compiler flag broken #119

psychocoderHPC opened this issue Nov 6, 2020 · 1 comment

Comments

@psychocoderHPC
Copy link
Member

The newly introduced CMake flag ISAAC_AO_BUG_FIX introduced in #112 is not given to the compiler and therefore ambient occlusion is still broken.

see: https://github.com/ComputationalRadiationPhysics/isaac/pull/112/files#r518781765

The define must be added via cmake target compile definitions.
@psychocoderHPC
Copy link
Member Author

dublicate of #120 (cmake was showing an error but was creating the issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@psychocoderHPC