Windows compile issues #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- less #defines in code - works now also with <cmath> (previous fix only worked with <math.h>)
- CMakeLists.txt did not remove graybat correctly - `#ifdef` sections in `types.cc` was missing
- Printing of colors is very different in windows and linux - `dout` has a lot of `#ifdef` now. This needs to be changed in the future (will create an issue) - `ray_histogram.cc` apparently uses colors directly. So I added a lot of code for that as well (probably going to be another issue) - length of the progressbar was reduced from 50 to 16 for Windows, since the Terminals have a (short) maximum fixed width. This appears to be a mit better with PowerShell, but is an issue nevertheless.
This was referenced Aug 31, 2015
slizzered
modified the milestones:
1.7. - extended features,
1.4 Graybat, usability and Windows compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a bunch of issues still wrong with the project when I tried to build for Windows. This is a cumulative PullRequest for all the issues that were blocking the build. One commit for each problem:
M_PIonly defined when some magic definition is set. This did work with<math.h>but had some problems with<cmath>. Found a good solution.filename.comparewas not 100% clear to the microsoft compiler, I did make it explicit which is nice.doutvery much, see dout Windows compatibility is really ugly #90 and ray_histogram.cc has separate implementation for Windows #91