Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unittest for stakingmiddleware module #426

Open
wants to merge 3 commits into
base: release/v6.4.x
Choose a base branch
from

Conversation

tungleanh0902
Copy link
Contributor

No description provided.

@tungleanh0902 tungleanh0902 changed the title unittest for stakingmiddleware module test: unittest for stakingmiddleware module Jan 23, 2024
@tungleanh0902 tungleanh0902 force-pushed the test/stakingmiddleware branch 2 times, most recently from 2d469e2 to 2d035eb Compare January 23, 2024 07:58
@hoank101 hoank101 self-requested a review January 24, 2024 03:06
Copy link
Collaborator

@hoank101 hoank101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

auto-merge was automatically disabled January 24, 2024 03:35

Head branch was pushed to by a user without write access

auto-merge was automatically disabled January 24, 2024 03:41

Head branch was pushed to by a user without write access

@kkast
Copy link
Contributor

kkast commented Jan 24, 2024

interchain tests dont pass

@blasrodri
Copy link

interchain tests dont pass

why not? Can you fix?

@nghuyenthevinh2000
Copy link
Collaborator

nghuyenthevinh2000 commented Mar 7, 2024

can you guys check access token settings?

the PR here is forbidden from pulling required image in Interchain Tests

Screenshot 2024-03-07 at 11 00 46

@blasrodri
Copy link

can you guys check access token settings?

the PR here is forbidden from pulling required image in Interchain Tests

Screenshot 2024-03-07 at 11 00 46

checking

@Ciejo
Copy link

Ciejo commented Mar 8, 2024

can you guys check access token settings?

the PR here is forbidden from pulling required image in Interchain Tests

Screenshot 2024-03-07 at 11 00 46

When you fork a repository in GitHub, the forked repository inherits certain permissions and settings from the original repository, including access controls for Docker images in GHCR. By default, forked repositories do not have permissions to push Docker images to GHCR, even if you have write access to the forked repository.

Checking the members of the repo I saw that you have write access to it, you can generate a Personal Access Token (PAT) with the necessary permissions (read:packages and write:packages) and use it in your GitHub Actions workflow to authenticate and push Docker images to GHCR.

Let me know if that works please.

@tungleanh0902
Copy link
Contributor Author

tungleanh0902 commented Mar 11, 2024

Hi @Ciejo, I added my PAT with r/w packages into repository secrets of the forked repo but it stays the same error. Does your repo have repo secret named GITHUB_TOKEN? Github does not allow me to add a secret named GITHUB_ so I have to change its name. (notional-labs#12)

@Ciejo
Copy link

Ciejo commented Mar 15, 2024

Hi @Ciejo, I added my PAT with r/w packages into repository secrets of the forked repo but it stays the same error. Does your repo have repo secret named GITHUB_TOKEN? Github does not allow me to add a secret named GITHUB_ so I have to change its name. (notional-labs#12)

Hello, sorry for the delay. I already added a PAT to our company organization. Can you merge your PR in notional repo and try to run again the workflow please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants