Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show property name on failing JSON schema assertions #105

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Show property name on failing JSON schema assertions #105

wants to merge 2 commits into from

Conversation

francislavoie
Copy link

Fixes #104

@W0rma
Copy link
Contributor

W0rma commented Jul 11, 2024

@francislavoie I wonder if the tests could be adjusted to verify that the new logic works as expected.

This can be achieved by adjusting the expected exception messages in https://github.com/francislavoie/module-rest/blob/abc599a9992db4ed2d6f6165a6b3ad8fe901ae89/tests/unit/Codeception/Module/RestTest.php#L715. WDYT?

@francislavoie
Copy link
Author

Sorry for the wait, added a test @W0rma

@francislavoie
Copy link
Author

FYI @TavoNiievez just in case this got missed 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W0rma W0rma W0rma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get which property failed with seeResponseIsValidOnJsonSchemaString
2 participants
@francislavoie @W0rma