Add verify_eigrp_interfaces_timers API to verify.py ios/iosxe eigrp protocol (my previous contribution) supporting EIGRPv4 and EIGRPv6 for IOS/IOSXE #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add mock for verify_eigrp_interfaces_timers
…verify_eigrp_interfaces_timers/mock_data/iosxe/test
Add test_api_verify_eigrp_interfaces_timers.py
Add verify_eigrp_interfaces_timers APIs for IOSXE/IOS EIGRP verify supporting ipv4 and ipv6 to my previous contribution verify.py
Add changelog_add_verify_eigrp_interfaces_timers_apis_202419041835
|
Hi @omehrabi, I would just like to point out that I took into consideration for this PR all your remarks from my previous contribution. Thank you |
|
Hi @omehrabi @domachad @Harishv01 can you please review my PR, I submitted it since 02 weeks. |
domachad
requested changes
May 9, 2024
.../apis/tests/iosxe/eigrp/verify/verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml
Outdated
Show resolved
Hide resolved
omehrabi
reviewed
May 9, 2024
The change according to comments and suggestions
The change to add "show version | include operating mode: ''"
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
New with suggested modification
…verify_eigrp_interfaces_timers/mock_data/iosxe directory
…verify_eigrp_interfaces_timers/mock_data/iosxe/tst
…verify_eigrp_interfaces_timers/mock_data/iosxe/mock_data.yaml Co-authored-by: Douglas Monteiro <84336224+domachad@users.noreply.github.com>
New verify.py
|
I tried many times always test failed! |
…verify_eigrp_interfaces_timers/mock_data/iosxe directory
New mock_data
…verify_eigrp_interfaces_timers/mock_data/iosxe/test
New verify.py file
|
@omehrabi @domachad @SohanTirpude @Harishv01 I think it is better to close this PR since always tests fail when I try to update my PR according to remarks and since there is no answer why from reviewers. Thanks |
…verify_eigrp_interfaces_timers directory
…imers_apis_202419041835.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added verify_eigrp_interfaces_timers API to verify.py (my previous contribution) for ios/iosxe eigrp protocol.
I added the tests folder verify_eigrp_interfaces_timers at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify
I added the changelog_add_verify_eigrp_interfaces_timers_apis_202419041835 file at pkgs/sdk-pkg/changelog folder
Thank you for reviewing my contribution