-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify_eigrp_router_id API to verify.py ios/iosxe eigrp protocol (my old contribution) supporting EIGRPv4 and EIGRPv6 for IOS/IOSXE #158
Conversation
add changelog_add_verify_eigrp_router_id_202421031402
Delete the old one
Add new verify.py containing new API verify_eigrp_router_id
…verify_eigrp_router_id/mock_data/iosxe/tst
Add test_api_verify_eigrp_router_id.py
Hi @lsheikal @omehrabi please can you review and merge my PR since it is an addition to my previous contribution (verifi.py for iosxe eigrp) and I followed same logic based on reviewers from my previous PR @ThomasJRyan and @Lelor. |
there is a change in unicon.plugin which will break the unittest for genielibs please update tests after 24.3 release |
Hi @omehrabi I fixed the problem with the update tests after 24.3 release |
Thank you, Hi @omehrabi , the problem with the update is fixed |
Co-authored-by: Lukeman Hakkim <84532451+lsheikal@users.noreply.github.com>
Add new verify.py with the asked changes
Co-authored-by: Lukeman Hakkim <84532451+lsheikal@users.noreply.github.com>
Upload new One
Hi @lsheikal why there is problem with test? |
pull the latest dev and merge with your branch. And address my comments. |
Fixed Co-authored-by: Lukeman Hakkim <84532451+lsheikal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change applied
Hi @lsheikal same problem, I don't know way test failed |
verify.py with changes (suggestions from reviewers)
Hi @omehrabi @lsheikal thank you. should I modify 'AS_N' just for this API or for all previous APIs merged previously |
lets modify this parameter for this api. And kindly adhere to the pep8 standards hereafter. |
Change AS_N to auto_sys
Hi @omehrabi @lsheikal I changed 'AS_N' to 'auto_sys' in the API as requested |
Hi @lsheikal, are the changes OK or are there more to do besides "AS_N" (I change it as requested)? THANKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there have been a change in unicon please update to the latest version and record the mock data
…verify_eigrp_router_id/mock_data/iosxe/mock_data.yaml Delete old one
Add new mock_data.yaml
…verify_eigrp_router_id/mock_data/iosxe/test
…verify_eigrp_router_id/test_api_verify_eigrp_router_id.py Delete old one
Add new test_api_verify_eigrp_router_id.py
Hi @omehrabi I updated to the latest version and I updated mock data and tests. Thank you |
Hi @omehrabi Is there any other change to make or it is ok? Thanks |
Hi @omehrabi Is there any other change to make or it is ok? Thanks |
Hello,
I added verify_eigrp_router_id API to verify.py (my old contribution) for ios/iosxe eigrp protocol.
I added the tests at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify
I added the changelog_add_verify_eigrp_router_id_202421031402 file at pkgs/sdk-pkg/changelog folder
Thank you for reviewing my contribution