Add verify_eigrp_router_id API to verify.py ios/iosxe eigrp protocol (my old contribution) supporting EIGRPv4 and EIGRPv6 for IOS/IOSXE

[cherifimehdi]

Hello,

I added verify_eigrp_router_id API to verify.py (my old contribution) for ios/iosxe eigrp protocol.

I added the tests at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify

I added the changelog_add_verify_eigrp_router_id_202421031402 file at pkgs/sdk-pkg/changelog folder

Thank you for reviewing my contribution

[cherifimehdi]

Hello @omehrabi @lsheikal thank you for reviewing my PR.
Thanks

[cherifimehdi]

Hi @lsheikal @omehrabi please can you review and merge my PR since it is an addition to my previous contribution (verifi.py for iosxe eigrp) and I followed same logic based on reviewers from my previous PR @ThomasJRyan and @Lelor.
Thank you

[omehrabi]

there is a change in unicon.plugin which will break the unittest for genielibs please update tests after 24.3 release

[cherifimehdi]

Hi @omehrabi I fixed the problem with the update tests after 24.3 release

[cherifimehdi]

there is a change in unicon.plugin which will break the unittest for genielibs please update tests after 24.3 release

Thank you, Hi @omehrabi , the problem with the update is fixed

[cherifimehdi]

Hi @lsheikal why there is problem with test?

[lsheikal]

Hi @lsheikal why there is problem with test?

pull the latest dev and merge with your branch. And address my comments.

[cherifimehdi]

Fixed

[cherifimehdi]

I fixed this

[cherifimehdi]

Change applied

[cherifimehdi]

Hi @lsheikal same problem, I don't know way test failed

[cherifimehdi]

Hi @omehrabi @lsheikal I think problem with test fixed

[cherifimehdi]

Hi @omehrabi @lsheikal are the corrections I made OK or There are modifications to do? Thank you

[lsheikal]

Hi @omehrabi @lsheikal are the corrections I made OK or There are modifications to do? Thank you

you still have not addressed the comments, i can still see the parameter AS_N in upper case, which violates pep8 standards. change it to a meaningful parameter name in lowercase.

[cherifimehdi]

Hi @omehrabi @lsheikal are the corrections I made OK or There are modifications to do? Thank you

you still have not addressed the comments, i can still see the parameter AS_N in upper case, which violates pep8 standards. change it to a meaningful parameter name in lowercase.

Hi @omehrabi @lsheikal thank you. should I modify 'AS_N' just for this API or for all previous APIs merged previously

[lsheikal]

Hi @omehrabi @lsheikal are the corrections I made OK or There are modifications to do? Thank you

you still have not addressed the comments, i can still see the parameter AS_N in upper case, which violates pep8 standards. change it to a meaningful parameter name in lowercase.

Hi @omehrabi @lsheikal thank you. should I modify 'AS_N' just for this API or for all previous APIs merged previously

lets modify this parameter for this api. And kindly adhere to the pep8 standards hereafter.

[cherifimehdi]

Hi @omehrabi @lsheikal are the corrections I made OK or There are modifications to do? Thank you

you still have not addressed the comments, i can still see the parameter AS_N in upper case, which violates pep8 standards. change it to a meaningful parameter name in lowercase.

Hi @omehrabi @lsheikal thank you. should I modify 'AS_N' just for this API or for all previous APIs merged previously

lets modify this parameter for this api. And kindly adhere to the pep8 standards hereafter.

Hi @omehrabi @lsheikal I changed 'AS_N' to 'auto_sys' in the API as requested

[cherifimehdi]

Hi @lsheikal, are the changes OK or are there more to do besides "AS_N" (I change it as requested)? THANKS

[omehrabi]

there have been a change in unicon please update to the latest version and record the mock data

[cherifimehdi]

Hi @omehrabi I updated to the latest version and I updated mock data and tests. Thank you
Is there any other change to make or it is ok?

[cherifimehdi]

Hi @omehrabi @lsheikal Is there any other change to make or it is ok? Thanks

[cherifimehdi]

Hi @omehrabi Is there any other change to make or it is ok? Thanks

[cherifimehdi]

Hi @omehrabi Is there any other change to make or it is ok? Thanks