-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add verify.py for iosxe eigrp folder containing 02 APIs for EIGRPv4 and EIGRPv6 #156
Conversation
…verify_eigrp_interfaces/mock_data/iosxe/tst
Test for verify_eigrp_interfaces api
…verify_eigrp_neighbors/mock_data/iosxe/tst
Add test for verify_eigrp_neighbors api
Add changelog_add_eigrp_verify.py_apis_202405031904.rst for eigrp verify.py
Add verify.py file for eigrp containing 02 APIs
Add verify.py file for EIGRP
Hello @ThomasJRyan @Lelor can you please tell me why there is a problem in test step? there is Some checks were not successful but for me it is OK since I added previously get.py for EIGRP without any problem. Thank you |
Thank you @ThomasJRyan finally all checks passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. Unfortunately I think this PR will need some work before we can merge it in
Delete the old file
New verify.py with suggested changes
Hi @ThomasJRyan, thanks for reviewing my PR. I went through all the changes and tested it, it works perfectly. |
Some issues resolved concerning
Hello @ThomasJRyan @Lelor @SohanTirpude are the changes I made ok. Because I addressed all them. Thank you |
Hi @ThomasJRyan are the changes I made ok based on your review? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would really appreciate you running verify.py
through a formatter like black
or similar
Delete the old one
Verify.py updated with fixed changes
Hello @ThomasJRyan Thank you for your valuable comments. Now I used Black instead of Pylint and normally it is reformatted. I have made all the necessary changes based on your suggestions and feedback. Thanks for reviewing my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small things, but nothing worth blocking the PR further over. Thank you for the contribution!
Delete the old one
Update verify.py based on suggested changes
Hi @ThomasJRyan Thank you very much for your valuable remarks and taking time to review my PR and accepting my contribution. |
No problem! I'll get @Lelor on this review as soon as possible so we can get you all merged in |
Hello,
I noticed there is no verify.py file and verify apis for ios/iosxe eigrp protocol
I added verify.py file at pkgs/sdk-pkg/src/genie/libs/sdk/apis/iosxe/eigrp containing 02 APIs for EIGRPv4 and EIGRPv6:
I added all the tests at pkgs/sdk-pkg/src/genie/libs/sdk/apis/tests/iosxe/eigrp/verify containing the test results for the 02 APIs in verify.py
I added the changelog_add_eigrp_verify.py_apis_202405031904 file at pkgs/sdk-pkg/changelog folder
Thank you for reviewing my contribution