overlay: add in docker + crio #326
Conversation
Let's see if docker + crio will build.
|
@jlebon @mike-nguyen @ashcrow @peterbaouoft have a look |
| override-version: "1.13.1" | ||
| branch: docker-1.13.1-rhel | ||
| distgit: | ||
| branch: master |
There was a problem hiding this comment.
I don't think docker will work because of https://github.com/cgwalters/rpmdistro-gitoverlay/issues/24, right? (And looking at the latest spec file, it doesn't seem like that situation changed). cri-o should work though.
There was a problem hiding this comment.
I was able to build docker successfully using rdgo from git master in a F28 container.
I also built it successfully using a CentOS based rdgo container
So I think we are looking good?
There was a problem hiding this comment.
If you can build docker then the go issue is probably not an issue any longer. I think building openshift may be a bit harder, but I'm getting close to a solution in updates to os (which could be copied here as well).
There was a problem hiding this comment.
I've now built the entire overlay file using that CentOS container, so I'm feeling good about this.
Packages successfully built in this order:
SRPMBuild(filename=u'/rdgo/snapshot/centos-release-atomic-host-devel-0-ffb78dae28ff343453dca0af3aaf213a796f8a20.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/playground-0-5867a70acd2dcd2efa3542b43c453a935c343458.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/bubblewrap-0.2.1.4-56609f864757924cecd5ceeaef35e46a9c1351ea.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/atomic-devmode-0.3.7.0-f42200dcff22700d582ee6f39182e5e6ca3e5e44.7867c9c112d0991362b73bd981cbbcbe16afe02c.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/python-ipaddress-0-95335c6b9f0753824b4b365bcaa83af883a25f37.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/python-docker-py-0-b1442afb45f751e06a0b3a4abe862360d83dd636.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/libgsystem-2015.2.4-d606bec68ddfea78de4b03c3f3568afb71bdc1ce.a5f6d8efdba0810e575f7205323fd075ac0d8152.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/ostree-2018.4.80-986f176e7cd40618f40579a33b4a82cafeeee1df.7e10c8905ee28c186cc297842905def856e1a25e.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/libsolv-0-c3a72293d4f0378ce2c0104d815216d7c35c897a.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/rpm-ostree-2018.4.44-b03b6a2057e92d4bfb400653b48201e2ae2c5f8d.8e5fd5e7d64c45f36146e13080544e74c02a2612.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/rpm-ostree-toolbox-2018.1.0-dc7d96c39cc122853d5dcd2d4677bdc5039f7c1e.1cf04e7bb507d2299f6ef22d7f6bd33755b2aaab.srcsnap/', rpmwith=[], rpmwithout=[])
SRPMBuild(filename=u'/rdgo/snapshot/micro-yuminst-2016.2.1-5f6028d4f8fee7e15db9d29a6c976c3c39d719b4.srcsnap/', rpmwith=[], rpmwithout=[])
Retaining partial sucessful builds: centos-release-atomic-host-devel playground bubblewrap atomic-devmode python-ipaddress python-docker-py libgsystem ostree libsolv rpm-ostree rpm-ostree-toolbox micro-yuminst
Running: createrepo_c --no-database --update .
Directory walk started
Directory walk done - 57 packages
Loaded information about 57 packages
Temporary output repo path: ./.repodata/
Pool started (with 5 workers)
Pool finished
Success!
There was a problem hiding this comment.
This only for the existing overlay.yml file only right?
There was a problem hiding this comment.
Ah, yeah...so I initially commented everything out except docker and crio to see if they would build. Then I uncommented everything to see if the whole thing would build. But because the git sources for docker and crio did not change, they were not rebuilt.
So that's why the packages don't show up in the output.
There was a problem hiding this comment.
Makes sense now. I was wondering why I couldn't see them in the output. Nice work!
There was a problem hiding this comment.
So I think we are looking good?
IIUC, I think the issue is that rdgo is only actually respecting the docker source. Other sources like libnetwork, docker-novolume-plugin, rhel-push-plugin, docker-lvm-plugin, etc... are just fetched from dist-git. So we're assuming that the latest HEAD on that projectatomic/docker branch will play nice with whatever version of those other sources have last been uploaded to the lookaside. Depending how coupled those components are, it might cause issues.
There was a problem hiding this comment.
@jlebon it may, but I think this is fine for a POC.
In preparation for adding more of the packages of interest there[1]. But even right now, this will allow us to track ostree and rpm-ostree git master. [1] CentOS/sig-atomic-buildscripts#326
|
This doesn't appear necessary anymore. For RHCOS we are getting |
Let's see if docker + crio will build.