Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper component #675

Open
wants to merge 16 commits into
base: release/1.1.0
Choose a base branch
from
Open

Conversation

byohannes
Copy link
Collaborator

No description provided.

@byohannes byohannes marked this pull request as draft August 8, 2024 19:00
@byohannes byohannes changed the title Draft - Stepper component Stepper component Aug 8, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (62aedb9) to head (aa9b4d3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/1.1.0      #675   +/-   ##
===============================================
  Coverage         100.00%   100.00%           
===============================================
  Files                 86        91    +5     
  Lines               1599      1656   +57     
  Branches             561       573   +12     
===============================================
+ Hits                1599      1656   +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@byohannes byohannes marked this pull request as ready for review August 22, 2024 17:24
@byohannes byohannes mentioned this pull request Aug 23, 2024
8 tasks
@alexwbbr
Copy link
Collaborator

alexwbbr commented Sep 9, 2024

@byohannes please can you change how the component is being rendered.
Screenshot 2024-09-09 at 17 44 07
With your current method the content can only take up 1/3 of the maximum screen size with 3 steps instead of being able to have a wider width.

Please can you make it so that the header and the content render separately

Screenshot 2024-09-09 at 17 45 28

As you can see from the angular material example the header and content are separate which then gives us greater control on how the component can look

@byohannes
Copy link
Collaborator Author

@alexwbbr, thanks for the review; I have updated the component to reflect the above-requested changes, and now each step does have a separate header and content as shown below

Screenshot 2024-09-10 at 15 53 23

@byohannes
Copy link
Collaborator Author

I have implemented the required changes @alexwbbr on the latest changes as shown on the attached images:

Screenshot 2024-09-13 at 14 47 29

Screenshot 2024-09-13 at 14 47 48

@byohannes byohannes self-assigned this Sep 14, 2024
@byohannes byohannes added the new component new component label Sep 14, 2024
@byohannes byohannes added this to the 1.1.0 milestone Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component new component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants