This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
submit questions on paste #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahularya50
suggested changes
Sep 23, 2020
apps/js/Question.js
Outdated
| @@ -158,6 +166,7 @@ export default function Question({ | |||
| onChange={(e) => { | |||
| setValue(e.target.value); | |||
| }} | |||
| onPaste={submit} | |||
There was a problem hiding this comment.
This may not work, because the value state would not have updated in the submit closure. You want to write a handlePaste that calls submitValue with the pasted value.
There was a problem hiding this comment.
oh how I've missed the javascript event loop..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.