Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary gltf support (.glb) #32

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

julianstirling
Copy link
Contributor

Adding glb support as no codec existed. It is in a new module rather than in the existing gltf one as I couldn't see how to make it work in the existing one.

@jmwright
Copy link
Member

@julianstirling Thanks, I think we will need to add a test for this, even if it is only checking error codes and for the existence of the file.

https://github.com/CadQuery/cq-cli/blob/main/tests/test_gltf_codec.py

@jmwright
Copy link
Member

@julianstirling The linter is complaining about extra lines at the end of the file. I tested your branch with a stereoscope assembly that I have on my system and it works well. Thanks.

@julianstirling
Copy link
Contributor Author

Linter fixes pushed

@jmwright jmwright merged commit c7a5f5c into CadQuery:main May 20, 2024
3 checks passed
@jmwright
Copy link
Member

Great, thanks. It's merged into main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants