Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPPSE-2783: Added fix for the null TIN root id issue #1467

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

sivaksb
Copy link
Contributor

@sivaksb sivaksb commented Oct 21, 2024

Information

  • When root id for TIN value is null, CT returns unexpected error. Fixed to return valid error message.

Checklist

  • All JUnit tests pass (mvn clean verify).
  • New unit tests written to cover new functionality.
  • Added and updated JavaDocs for non-test classes and methods.
  • No local design debt. Do you feel that something is "ugly" after your changes?
  • Updated documentation (README.md, etc.) depending if the changes require it.

Comment on lines +115 to +116
SpecPiiValidator validator = validator("DogCow_APM", "DogCow_NPI");
Node node = node("Invalid_Apm", "DogCow_NPI,DogCow_NPI2", "DogCow", PCF_PROGRAM_NAME);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶 🐮

Jpec07
Jpec07 previously approved these changes Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

@sivaksb sivaksb merged commit 4337309 into develop Oct 23, 2024
5 checks passed
@sivaksb sivaksb deleted the feature/QPPSE-2783-FIX_TIN_Validation_Errors branch October 23, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants